Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich DynamicOracle with more obstacle/note utilities for automatic pathing #54

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

JohnGilb
Copy link
Contributor

@JohnGilb JohnGilb commented Jan 30, 2024

Why are we doing this?

To take more advantage of dynamic pathing in the SCL.
Asana task URL:

Whats changing?

  • Adds extremely simple physics simulation to drive in the simulator via moving average of inputs
  • Adds red obstacles, as well as red notes to DynamicOracle and NoteMap
  • Adds a nice visualizer for obstacle boundaries in AdvantageScope
  • Minor bugfixes

Questions/notes for reviewers

How this was tested

  • unit tests added
  • tested on robot

@JohnGilb JohnGilb requested a review from a team as a code owner January 30, 2024 02:46
src/main/java/competition/Robot.java Show resolved Hide resolved
src/main/java/competition/Robot.java Outdated Show resolved Hide resolved
speaker.defaultTopLeft = false;

// Red obstacles
createObstacleWithRobotWidth(BasePoseSubsystem.convertBlueToRed(PoseSubsystem.BlueLeftStageColumn),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ idle thought, is there a way we could do this in obstacle space instead so we don't have to individually convert each landmark here? eg for obstacle : obstacles { add flipped version }

@JohnGilb JohnGilb merged commit 6eaf22c into main Jan 31, 2024
1 check passed
@JohnGilb JohnGilb deleted the feature/ImprovePathing branch January 31, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants